Merged
Conversation
Closed
1 task
JiWoo1261
approved these changes
Jul 9, 2025
Collaborator
JiWoo1261
left a comment
JiWoo1261
left a comment
There was a problem hiding this comment.
처음보다 코드가 많이 깔끔해진 것 같아요! 수고햇더여. .🥵
sonms
approved these changes
Jul 9, 2025
|
|
||
| @Preview(showBackground = true) | ||
| @Composable | ||
| fun PreviewLoginScreen() { |
| .padding(horizontal = 16.dp, vertical = 48.dp) | ||
| .background(color = PawKeyTheme.colors.white1) | ||
| ) { | ||
| Column( |
Member
There was a problem hiding this comment.
여기 부분 column 없이 가능할 거 같은데 깊어질 수록 성능저하가 발생하기 때문에 확인해주세용
Comment on lines
+91
to
+97
| splashNavGraph( | ||
| paddingValues = paddingValues, | ||
| navigateUp = navigator::navigateUp, | ||
| navigateNext = navigator::navigateDummyNext, | ||
| navigateLogin = navigator::navigateLogin, | ||
| snackBarHostState = snackbarHostState | ||
| ) |
Member
There was a problem hiding this comment.
navigateNext 자체가 splash의 다음을 지정하는거라 navigateLogin을 따로 만들어서 할 필요가 없을 것 같아요~ 밑에도 다시 확인해주세여~
|
|
||
| @Preview(showBackground = true) | ||
| @Composable | ||
| fun PreviewSplashScreen() { |
Member
There was a problem hiding this comment.
private!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?!?"~!?
| Column(horizontalAlignment = Alignment.CenterHorizontally) { | ||
| Icon( | ||
| imageVector = ImageVector.vectorResource(id = R.drawable.ic_logo_draft), | ||
| contentDescription = stringResource(id = R.string.ic_logo), |
Comment on lines
+29
to
+35
| init { | ||
| viewModelScope.launch { | ||
| delay(1800) | ||
| _sideeffect.emit(SplashContract.SplashSideEffect.NavigateToLogin) | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
뷰모델에서 delay로 직접 처리할 시 UI 상태 관리와는 별개의 UI 전환 로직을 포함하는 것이기 때문에 지양하고 UI에서 진행해주세요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: pull_request_template
about: pr 생성용 템플릿입니다~
title: ''
labels: ''
assignees: ''
ISSUE
❗ WORK DESCRIPTIONAdd commentMore actions
📸 SCREENSHOT
splash.mp4
📢 TO REVIEWERS