Merged
Conversation
Closed
2 tasks
vvan2
approved these changes
Jul 9, 2025
| Box( | ||
| modifier = Modifier | ||
| .size(40.dp) | ||
| .background(Color.Gray, RoundedCornerShape(20.dp)) |
Collaborator
Author
There was a problem hiding this comment.
민성띠 뷰에서도 쓰이길래 낋여옴
| modifier = modifier | ||
| .fillMaxWidth() | ||
| .background(Color(0xFFF7F7F7)) | ||
| ) { |
| Icon( | ||
| imageVector = ImageVector.vectorResource(R.drawable.ic_arrow_left_black), | ||
| contentDescription = "뒤로가기" | ||
| ) |
Member
There was a problem hiding this comment.
이미지 description string 값으로 관리하는게 좋다고 하네요
| } | ||
| } | ||
| } | ||
| } |
|
|
||
| @Preview | ||
| @Composable | ||
| fun SavedCourseDetailPreview(){ |
| val location: String, | ||
| val distance: String, | ||
| val time: String | ||
| ) |
Member
There was a problem hiding this comment.
data class 는 state쪽에 따로 관리하는게 좋을듯함니두
Member
There was a problem hiding this comment.
나중에 서버에서 받아오고 사용할 data class라면 domain -> entity 그냥 ui 관리용으로 사용할거면 state
sonms
approved these changes
Jul 10, 2025
Member
sonms
left a comment
sonms
left a comment
There was a problem hiding this comment.
우다다다 하시느라 컴포넌트 depth가 많아진 것 같네요잉? 좀 더 간결하게 같은 디자인의 컴포넌트를 만들 수 있도록 화이팅!
| Column( | ||
| modifier = modifier | ||
| .fillMaxWidth() | ||
| .background(Color.White) |
| ) | ||
| Spacer(modifier = Modifier.width(10.dp)) | ||
| Column { | ||
| Text(title, style = PawKeyTheme.typography.body14M, |
Comment on lines
+82
to
+83
| .width(343.dp) | ||
| .height(156.dp) |
| } | ||
| @Preview(showBackground = true) | ||
| @Composable | ||
| fun CourseCardPreview() { |
| Icon( | ||
| imageVector = ImageVector.vectorResource(R.drawable.ic_arrow_left_black), | ||
| contentDescription = "뒤로가기" | ||
| ) |
| } | ||
| } | ||
| } | ||
| } |
|
|
||
| @Preview(showBackground = true) | ||
| @Composable | ||
| fun CourseDetailPreview() { |
| modifier: Modifier = Modifier | ||
| ){ | ||
| Column( | ||
| modifier = Modifier |
Member
There was a problem hiding this comment.
상위거로 사용하는 이유는 상위에서 하위컴포넌트를 조절하기 위함이 가장 큽니다 나중에 주완이형이랑 손잡고 같이 공부해오기
| val location: String, | ||
| val distance: String, | ||
| val time: String | ||
| ) |
Member
There was a problem hiding this comment.
나중에 서버에서 받아오고 사용할 data class라면 domain -> entity 그냥 ui 관리용으로 사용할거면 state
Comment on lines
+100
to
+107
| @Serializable | ||
| data object UserProfile | ||
| @Serializable | ||
| data object PetProfile | ||
| @Serializable | ||
| data object SavedCourseList | ||
| @Serializable | ||
| data object ArchivedCourseList No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: pull_request_template
about: pr 생성용 템플릿입니다~
title: ''
labels: ''
assignees: ''
ISSUE
❗ WORK DESCRIPTIONAdd commentMore actions
📸 SCREENSHOT
📢 TO REVIEWERS
빠르게 리팩터링하고 디테일도 반영하겠습니다!!
피드백은 언제든 환영입니다 🙇♀️🙇