[feat/#35] onboarding signup 뷰 구현 by vvan2 · Pull Request #47 · PAW-KEY/PAWKEY-Android

vvan2 · 2025-07-11T10:34:17Z

name: pull_request_template
about: pr 생성용 템플릿입니다~
title: ''
labels: ''
assignees: ''

ISSUE

closed [feat] 온보딩/회원가입 뷰 구현 #35

❗ WORK DESCRIPTIONAdd commentMore actions

onboarding_signup 컴포넌트 생성
onboarding_signup 회원가입 뷰 구현
onboarding_signup viewmodel,state 로 로직 구현
onboarding_signup string, img 추가
mainnavigation, navhost 에 회원가입 플로우 추가
home,splash 코드 리펙토링

📸 SCREENSHOT

BEFORE	AFTER

📢 TO REVIEWERS

리뷰어에게 전달해야 하는 말

JiWoo1261 · 2025-07-11T13:24:36Z

app/src/main/java/com/paw/key/presentation/ui/signup/viewmodel/SignUpViewModel.kt

+
+    private val _sideEffect = MutableSharedFlow<SignUpContract.SignUpSideEffect>()
+    val sideEffect: MutableSharedFlow<SignUpContract.SignUpSideEffect>
+        get() = _sideEffect


sideEffect가 정의되어 있는데 현재 사용되고 있지는 않네요..?
추후에 버튼 클릭 등의 이벤트 처리에 활용할 예정이실까용??? 😲

sideeffect 일어나는 요소중 아직 , navigation을 통한 이벤트 처리만 구현했어서 이후에, 디테일 잡을 때 고려해서 추가해보겠습니다!

sonms

고생하셨습니다! 현재는 각 회원가입마다 페이지가 구현되어있는데 회원가입 플로우는 하나의 페이지에서 이뤄지는 느낌이기 때문에
HorizontalPager( state = pagerState, userScrollEnabled = false, pager 형태로 스크롤을 제한하고 넘기는 식으로 해보는 것도 좋을 것 같습니다!

sonms · 2025-07-11T12:34:35Z

app/src/main/java/com/paw/key/core/designsystem/component/CourseDetail.kt

                        color = PawKeyTheme.colors.gray200
                    )
-                    Divider(modifier = Modifier.padding(10.dp))
+                    HorizontalDivider(modifier = Modifier.padding(10.dp))


sonms · 2025-07-11T12:50:39Z

app/build.gradle.kts

+    // 회원가입
+    implementation ("androidx.compose.foundation:foundation:1.4.0")
+


뺏으니까 확인 필요하면 toml에 설정할 수 있도록 해주세요

sonms · 2025-07-11T12:52:22Z

app/src/main/java/com/paw/key/presentation/ui/home/HomeScreen.kt

@@ -1,3 +1,5 @@
+@file:Suppress("DEPRECATION")


? 확인예정

sonms · 2025-07-11T12:56:30Z

app/src/main/java/com/paw/key/presentation/ui/home/HomeScreen.kt

+    viewModel: HomeViewModel = hiltViewModel(),
 ) {
-    val isLocationMenuVisible = viewModel.isLocationMenuVisible
+    val state by viewModel.state.collectAsState()


collectAsState는 Composable 앱이 백그라운드로 가거나 화면이 가려져도 Flow는 계속 데이터를 발행하고 이에 따라 UI 상태도 계속 업데이트될 수 있습ㄴ니다 그렇기에?! 안드로이드 생명주기에 맞게 조정될 수 있도록 collectAsStateWithLifecycle로 해주세요

생명주기 생각하면서 적용해보겠습니답

sonms · 2025-07-11T12:58:51Z

app/src/main/java/com/paw/key/presentation/ui/home/component/SettingButton.kt


 @Composable
-internal fun SettingButton(){
+fun SettingButton(){


상위에서 하위 컴ㅁ포넌트를 아직은 조절하지 않더라도 꼭 선언해서 사용해주세요 재사용성을 위해 통로를 열어두는 것을 위해!

sonms · 2025-07-11T13:44:57Z

app/src/main/java/com/paw/key/presentation/ui/signup/component/SignUpLoationGrid.kt

+}
+
+@Composable
+fun SignUpLoationGrid(


Grid를 네이밍에 나타냈는데 LocationButton만있는데 의도하신건가요?

sonms · 2025-07-11T13:45:40Z

app/src/main/java/com/paw/key/presentation/ui/signup/component/SignUpTextField.kt

+    value: String,
+    onValueChange: (String) -> Unit,
+    modifier: Modifier = Modifier,
+    placeholder: String = "",


placeholder를 받아와서 사용하는 재사용 컴포넌트인데 placeholder에 기본값을 주신이유가 있을까요?

sonms · 2025-07-11T13:45:51Z

app/src/main/java/com/paw/key/presentation/ui/signup/component/SignUpTextField.kt

+    placeholder: String = "",
+    enabled: Boolean = true,
+) {
+    val isClicked = remember { mutableStateOf(false) }


허허 상태관리

sonms · 2025-07-11T13:47:22Z

app/src/main/java/com/paw/key/presentation/ui/signup/navigation/SignUpActivityNavigation.kt

+    navigate(SignUpActivity, navOptions)
+}
+
+fun NavGraphBuilder.signupactivityNavGraph(


camel case 지켜주세요 signUpActivity

sonms · 2025-07-11T13:47:45Z

app/src/main/java/com/paw/key/presentation/ui/signup/navigation/SignUpLevelNavigation.kt

+    navigate(SignUpLevel, navOptions)
+}
+
+fun NavGraphBuilder.signupLevelNavGraph(


마찬가지로 카멜케이스

vvan2 added 12 commits July 11, 2025 19:03

feat/#35: onboarding string 요소 추가

7d45082

feat/#35: Home component 접근제어자 수정

53f8d20

feat/#35: 이미지 추가

46d5f24

feat/#35: 컴포넌트 의존성 추가

46cddf1

feat/#35: home component 수정

f07c21c

feat/#35: splash 수정

26ad086

feat/#35: 오류 및 파라미터 수정

3586351

feat/#35: onboarding_signup 컴포넌트 생성

32762e8

feat/#35: navigation 수정

f90b4c4

feat/#35: onboarding_signup viewmodel,state

33d3d76

feat/#35: onboarding_signup 패키지 내부 컴포넌트

7234c02

feat/#35: onboarding_signup 회원가입 flow 뷰,네비게이션

8bfe2c3

vvan2 self-assigned this Jul 11, 2025

vvan2 added feature ✨ 새로운 기능 구현 🐻주완 주완 전용 라벨 labels Jul 11, 2025

vvan2 linked an issue Jul 11, 2025 that may be closed by this pull request

[feat] 온보딩/회원가입 뷰 구현 #35

Closed

1 task

github-actions bot requested a review from JiWoo1261 July 11, 2025 10:34

JiWoo1261 approved these changes Jul 11, 2025

View reviewed changes

sonms approved these changes Jul 11, 2025

View reviewed changes

vvan2 merged commit eec3207 into develop Jul 11, 2025
1 check passed

vvan2 deleted the feat/#35-onboarding-signup branch July 11, 2025 14:01

		// 회원가입
		implementation ("androidx.compose.foundation:foundation:1.4.0")

Conversation

vvan2 commented Jul 11, 2025

ISSUE

❗ WORK DESCRIPTIONAdd commentMore actions

📸 SCREENSHOT

📢 TO REVIEWERS

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonms left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants