Conversation
Closed
1 task
JiWoo1261
approved these changes
Jul 11, 2025
Collaborator
JiWoo1261
left a comment
JiWoo1261
left a comment
There was a problem hiding this comment.
수고용~~ 공통 컴포넌트 만들어왔더요;;;;;
| if (state.isLocationMenuVisible) { | ||
| LocationList( | ||
| selected = state.selectedLocation, | ||
| locations = listOf("개포동", "논현동", "뭔동", "동동동", "스꾸삐", "4글자유"), |
sonms
requested changes
Jul 12, 2025
| navigateNext: () -> Unit, | ||
| navigateHomeLocationSetting: () -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| viewModel: HomeViewModel = hiltViewModel(), |
Member
There was a problem hiding this comment.
뷰모델을 파라미터로 넘길 경우 재사용성과 생명주기의 문제와 의존성 주입 원칙에 위배되기 때문에 state.~로 관찰한 값을 넘겨주세요
|
|
||
| Spacer(modifier = Modifier.weight(1f)) | ||
|
|
||
| val isFormValid = state.selectedLocation.isNotEmpty() |
| text = stringResource(id = R.string.ic_onboarding_signup_button), | ||
| enabled = isFormValid, | ||
| onClick = { | ||
| if (isFormValid) { |
| ) { | ||
| Icon( | ||
| imageVector = ImageVector.vectorResource(id = R.drawable.ic_home_setting), | ||
| contentDescription = "setting", |
Member
There was a problem hiding this comment.
ㅎㅎ 모든 description의 하드 코딩은 지양 해야하지용?
| } | ||
|
|
||
| @Serializable | ||
| data object HomeLocationSetting : MainTabRoute No newline at end of file |
Member
There was a problem hiding this comment.
놉 지역 설정은 메인탭의루트가 아니죠? 단순
화면의 이동은 route로 해야합니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: pull_request_template
about: pr 생성용 템플릿입니다~
title: ''
labels: ''
assignees: ''
ISSUE
❗ WORK DESCRIPTIONAdd commentMore actions
📸 SCREENSHOT
Android.Emulator.-.Pixel_8a_API_35_5554.2025-07-12.01-54-14.mp4
📢 TO REVIEWERS