Conversation
1 task
sonms
approved these changes
Jul 12, 2025
Comment on lines
+165
to
+166
| item{} | ||
| item{} |
| Spacer(modifier = Modifier.weight(1f)) | ||
|
|
||
| val isFormValid = state.selectedLocation.isNotEmpty() | ||
| val isFormValid = state.selectedLocation.isNotEmpty() |
Member
There was a problem hiding this comment.
폼 판별 변수는 상태로 뷰모델에서 map과 statein으로 관리해보아용
| val isFormValid = state.name.isNotBlank() && | ||
| state.age.isNotBlank() && | ||
| state.selectedGender != SignUpContract.Gender.UNKNOWN | ||
| val isFormValid = state.name.isNotBlank() && |
| onValueChange: (String) -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| placeholder: String = "", | ||
| placeholder: String, |
Member
There was a problem hiding this comment.
기본값이 필요없었다면? Compose 파라미터 기준에 따라 modifier 위로~
| ) | ||
| Column( | ||
| modifier = Modifier | ||
| .fillMaxSize() |
Member
There was a problem hiding this comment.
상위에서 fillmaxsize인데 여기서 fillmaxsize로 가린 이유가 있을까요?
Member
Author
There was a problem hiding this comment.
하위 요소들만 16dp라 중첩해서 넣었는데 하위 column쪽 요소는 빼고 수정하겠습니다
| ) | ||
| } | ||
|
|
||
| private fun isAgeValid(ageKnown: SignUpContract.AgeKnown, dogAge: String): Boolean { |
Comment on lines
+66
to
+70
| Column( | ||
| modifier = Modifier | ||
| .fillMaxSize() | ||
| .padding(horizontal = 16.dp) | ||
| ) { |
Member
There was a problem hiding this comment.
여기도 마찬가지로 상위에 fillmaxsize인데 여기서 flllmaxsize 인 이유?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: pull_request_template
about: pr 생성용 템플릿입니다~
title: ''
labels: ''
assignees: ''
ISSUE
❗ WORK DESCRIPTIONAdd commentMore actions
📸 SCREENSHOT
📢 TO REVIEWERS