Use assert() for unreachable assertions #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NWilson
force-pushed
the
user/niwilson/assert-unreachable
branch
from
fa7cc34 to
31b0988
Compare
carenas
approved these changes
Oct 30, 2024
Contributor
carenas
left a comment
carenas
left a comment
There was a problem hiding this comment.
It would be probably nicer to refactor it slightly so there is only one #include <assert.h> though
NWilson
force-pushed
the
user/niwilson/assert-unreachable
branch
from
31b0988 to
9675951
Compare
Member
Author
|
Good thinking. I pulled out the |
Collaborator
|
@carenas is this patch ok now? |
Contributor
|
Yes, merge it please; @zherczeg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using assert rather than abort will give a (very slightly) better error message, which includes the containing function name.
Only affects Debug builds.