Add test output to make erroroffsets more readable #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NWilson
force-pushed
the
user/niwilson/erroroffset-existing-tests
branch
from
7e7730c to
e83c753
Compare
zherczeg
reviewed
May 14, 2025
|
|
||
| /(?(n/utf | ||
| Failed: error 142 at offset 4: syntax error in subpattern name (missing terminator?) | ||
| here: (?(n |<--| |
Collaborator
There was a problem hiding this comment.
I often see using the caret (^)
/(?(n/utf
^
Failed: error 142 at offset 4: syntax error in subpattern name (missing terminator?)
Member
Author
There was a problem hiding this comment.
That would be a better user interface for an actual tool using PCRE2. I did consider it, and even attempted it. However, editors and terminals differ in how they render Unicode combining characters with multiple codepoints, for example characters with decomposing accents. Rendering the caret on the line below would be less precise for the purpose of a testing tool.
So, I chose to use this approach in pcre2test for maximal clarity.
NWilson
force-pushed
the
user/niwilson/erroroffset-existing-tests
branch
from
e8e39e0 to
534e04c
Compare
carenas
added a commit
to carenas/pcre2
that referenced
this pull request
Aug 4, 2025
No longer needed Since 716c1fd (Add test output to make erroroffsets more readable (PCRE2Project#750), 2025-05-21).
carenas
added a commit
to carenas/pcre2
that referenced
this pull request
Aug 6, 2025
No longer needed Since 716c1fd (Add test output to make erroroffsets more readable (PCRE2Project#750), 2025-05-21).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pcre2test prints the
erroroffsetas a simple number, which makes it impossible in the test output to see where it's actually pointing.I have added printing of the relevant portion of the pattern, to show visually where the offset points.
There is also a new function
error_direction()where I have started to classify which PCRE2 errors point to the left or right of the erroroffset. When I have fixed this all to be consistent to my satisfaction, I will document this so that clients have a better way to indicate which character is wrong in a regex.This PR is almost test-only, with just a handful of tiny changes in pcre2_compile.c.