Remove memmove, bcopy, and VPCOMPAT macros #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carenas
approved these changes
Sep 26, 2025
Contributor
carenas
left a comment
carenas
left a comment
There was a problem hiding this comment.
build.zig also needs updating though
Member
Author
|
Oops! Thank you. I missed that because my editor is usually set to exclude |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
memmovefunction dates back to C89, and has been available in all systems since 1993 (when SunOS 5 and BSD 4.4 were released).The Visual Pascal compiler had its last release in 2003 and its original author posted in 2005 that "Virtual Pascal has died". Those macros can also be removed now.
The only reason I want to be proactive about this is because many users incorporate the source files from PCRE2 into their own build system. Some of these users are undoubtedly getting the memmove fallback code, if they are not providing the HAVE_MEMMOVE macro. Our minimum supported C version is now C99, so there is no need for pre-C89 fallbacks.
See: #804