Skip to content

GS/HW: Test double buffer offset from target base address on lookup#13135

Merged
lightningterror merged 2 commits intoPCSX2:masterfrom
JordanTheToaster:goboom
Nov 25, 2025
Merged

GS/HW: Test double buffer offset from target base address on lookup#13135
lightningterror merged 2 commits intoPCSX2:masterfrom
JordanTheToaster:goboom

Conversation

@JordanTheToaster
Copy link
Copy Markdown
Member

@JordanTheToaster JordanTheToaster commented Aug 14, 2025

Description of Changes

Here's an explanation as I have no idea what this does myself.

"so basically what it's doing is checking if you offset by the size from the base address of the target, does that BP match the requested one, instead of making sure it's completely inside, as the game doesn't necessarily render the entire height, especially if there are black borders, causing the "Inside" check to fail"

Fixes #1140

Rationale behind Changes

This fixes FFX-2s FMV's in hardware mode fully using Tex in RT Inside Target.

Suggested Testing Steps

Test as many games and any FMV's you can this needs a lot of testing.

Did you use AI to help find, test, or implement this issue or feature?

No

@AmandaRoseChaqueta
Copy link
Copy Markdown

Probably this should be checked on silent hill 3, i remember looking similar to what FFX-2 had. I would love to test it but sadly can't, due to not having access to my pc.

@AmandaRoseChaqueta
Copy link
Copy Markdown

Tested SH3, sadly doesn't seem to fix the issue
image

@JordanTheToaster
Copy link
Copy Markdown
Member Author

Tested SH3, sadly doesn't seem to fix the issue

I've tried a few similar cases but they all seem to not react to this sadly.

@refractionpcsx2
Copy link
Copy Markdown
Member

SH3 wraps around the end of memory with an offset, which is what breaks SH3, it's not a double buffer issue unfortunately.

@AmandaRoseChaqueta
Copy link
Copy Markdown

SH3 wraps around the end of memory with an offset, which is what breaks SH3, it's not a double buffer issue unfortunately.

Well, that's a shame (At least the softwarefmv hack works fine!). But thank you for explanation.

@JordanTheToaster JordanTheToaster force-pushed the goboom branch 3 times, most recently from 4322bcf to 40c2799 Compare August 31, 2025 00:59
@Mrlinkwii
Copy link
Copy Markdown
Contributor

#12510 might be a good check on this with ( it has SWFMV atm)

Copy link
Copy Markdown
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fixes FF
image

Dump run looks good on dx11.

@lightningterror lightningterror merged commit 9b147cc into PCSX2:master Nov 25, 2025
13 checks passed
@JordanTheToaster JordanTheToaster deleted the goboom branch January 11, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Final Fantasy X-2 International - Video Issue when playing japanese video on title screen

6 participants