GS/GL: Try to use glBindTextures for binding multiple srv slots.#13325
Closed
lightningterror wants to merge 1 commit intomasterfrom
Closed
GS/GL: Try to use glBindTextures for binding multiple srv slots.#13325lightningterror wants to merge 1 commit intomasterfrom
lightningterror wants to merge 1 commit intomasterfrom
Conversation
lightningterror
force-pushed
the
gs_gl_bind_slots
branch
from
5dd9239 to
b774ff6
Compare
Use glBindTextures for 2 slots or more, should be generally faster, otherwise use glBindTextureUnit.
lightningterror
force-pushed
the
gs_gl_bind_slots
branch
from
b774ff6 to
e4b2e72
Compare
Contributor
Author
|
Not worth it, basically no difference, maybe if we used more slots then yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS/GL: Try to use glBindTextures for binding multiple srv slots.
Use glBindTextures for 2 slots or more, should be generally faster, otherwise use glBindTextureUnit.
Rationale behind Changes
Speed.
Suggested Testing Steps
Try games such as Sly 2, Star ocean, and other games that could use 2-3 slots (blending, palette tex), see if there's any speed up and if it's worth adding this, benchmark it.
Did you use AI to help find, test, or implement this issue or feature?
No.