GS/TC: Make sure target is created before setting any flags.#13389
Merged
lightningterror merged 1 commit intomasterfrom Oct 14, 2025
Merged
GS/TC: Make sure target is created before setting any flags.#13389lightningterror merged 1 commit intomasterfrom
lightningterror merged 1 commit intomasterfrom
Conversation
Xenosaga 3 fails to create a target because the rect is empty so we should avoid setting any flags since it's null.
|
Just tried this version and the game no longer crashes in the Data menu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS/TC: Make sure target is created before setting any flags.
Xenosaga 3 fails to create a target because the rect is empty so we should avoid setting any flags since it's null.
Rationale behind Changes
Fixes #13387
Suggested Testing Steps
Test #13387
Did you use AI to help find, test, or implement this issue or feature?
No.