Skip to content

Qt: Set default selection to "No" when closing while memory card is busy#13396

Closed
resadent wants to merge 2 commits intoPCSX2:masterfrom
resadent:memory-card-dialog-default-no
Closed

Qt: Set default selection to "No" when closing while memory card is busy#13396
resadent wants to merge 2 commits intoPCSX2:masterfrom
resadent:memory-card-dialog-default-no

Conversation

@resadent
Copy link
Copy Markdown
Contributor

Description of Changes

Set the dialog default button pressed to "No".

Rationale behind Changes

It may prevent people from accidentally erasing their memory cards. Fixes #13131.

Suggested Testing Steps

Pause a game when it is writing to a memory card, then close the emulator.
I did is in God of War II while it was saving and it worked fine.
pcsx2 proof it works

Did you use AI to help find, test, or implement this issue or feature?

No.

@resadent resadent changed the title Set default selection to "No" when closing while memory card is busy Qt: Set default selection to "No" when closing while memory card is busy Oct 15, 2025
@TheTechnician27
Copy link
Copy Markdown
Contributor

This does not fix #13131. The person posting the issue was using the FSUI, which is a tricky problem that I tried and failed to solve.

image

As you can see in the screenshot above, PCSX2 master already defaults to 'No' in the Qt UI. As far as I can tell, this PR does nothing to change the behavior of current master. The only line of code changed is if (res != QMessageBox::Yes) to if (msgbox.exec() != QMessageBox::Yes), and I can't immediately tell what that's supposed to be doing, because the current code clearly works.

@TheTechnician27
Copy link
Copy Markdown
Contributor

Also, incidentally, this pulls in @JordanTheToaster's macOS FFMPEG dependency commit by mistake. But there's no reason to merge the actual commit either, as it does not ostensibly do anything, let alone what is advertised.

@SternXD
Copy link
Copy Markdown
Contributor

SternXD commented Oct 16, 2025

yeah, this isn't related to the issue at all

@TheTechnician27
Copy link
Copy Markdown
Contributor

Closing as:

  1. Not addressing the issue [Feature Request]: Set default selection to "No" when closing while memory card is busy #13131 it claims to address.
  2. Instead "fixing" an alleged issue shown in screenshot which does not exist on current master.
  3. Inexplicably removing the grab for the dialog parent lock.
  4. Otherwise doing nothing that subjectively or objectively improves functionality or organization in any way.

@resadent
Copy link
Copy Markdown
Contributor Author

Thanks for the review, sorry I did not understand completely the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Set default selection to "No" when closing while memory card is busy

3 participants