Skip to content

Qt/BPM: Improve memory card shutdown warning messages for clarity #13400

Merged
TellowKrinkle merged 1 commit intoPCSX2:masterfrom
SternXD:fsui-memcardfix
Oct 16, 2025
Merged

Qt/BPM: Improve memory card shutdown warning messages for clarity #13400
TellowKrinkle merged 1 commit intoPCSX2:masterfrom
SternXD:fsui-memcardfix

Conversation

@SternXD
Copy link
Copy Markdown
Contributor

@SternXD SternXD commented Oct 16, 2025

image image

Fixes #13131

Description of Changes

  • Improved the memory card busy warning dialog message for better clarity and urgency on Qt, and BPM
  • on BPM Swapped the button order in the dialog so "No" (the safe option) appears first and is focused by default
  • Updated message text to be more direct and user-friendly
  • On Qt made the message a Warning rather then an error

Rationale behind Changes

The default button selection in the memory card busy dialog was previously set to "Yes" (shut down anyway), which could have lead to accidental memory card corruption if users quickly pressed the confirm button without reading the warning carefully.

By making "No" (don't shut down) the default selection on FSUI users are less likely to accidentally corrupt their memory cards. And making the Qt box a warning rather then an error makes more sense in my opinion since it's just warning the user that it's saving not that it failed to save.

Suggested Testing Steps

  1. Start a game or BIOS in PCSX2
  2. Trigger a memory card save operation (save in-game or BIOS)
  3. While the save is in progress (within ~5 seconds), attempt to shut down via the pause menu or hotkey
  4. Verify that:
    • The warning dialog appears with the new text on FSUI and Qt
    • On FSUI the 'No' option is first

Did you use AI to help find, test, or implement this issue or feature?

No.

@TellowKrinkle TellowKrinkle merged commit 8fb2940 into PCSX2:master Oct 16, 2025
12 checks passed
@SternXD SternXD deleted the fsui-memcardfix branch October 16, 2025 05:16
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Oct 19, 2025
--------------------------------------------------------------------------------------------------------
batocera-emulationstation.mk 665c5fa864e28eeb7b27e0f71f5ce3c694ac5956 # Version: Commits on Oct 16, 2025
--------------------------------------------------------------------------------------------------------
Merge pull request #1967 from SirRickster/add-free-disc-space-for-mounted-devices

Added disc free space for auto mounted disks /media/diskname,

------------------------------------------------------------------------------------------------
batocera-es-piboy.mk 665c5fa864e28eeb7b27e0f71f5ce3c694ac5956 # Version: Commits on Oct 16, 2025
------------------------------------------------------------------------------------------------
Merge pull request #1967 from SirRickster/add-free-disc-space-for-mounted-devices

Added disc free space for auto mounted disks /media/diskname,

-----------------------------------------------------------------------------------
ares.mk 5319fe68f0c9f0a65469638117d270f3fee663f8 # Version: Commits on Oct 16, 2025
-----------------------------------------------------------------------------------
screen: prevent blowing out brightness when increasing saturation.,

-----------------------------------------------------------------------------------
cemu.mk ef1c836290690dfbb0b60f40af7aadb2130a6437 # Version: Commits on Oct 15, 2025
-----------------------------------------------------------------------------------
UI: Move recent files into a submenu (#1707),

------------------------------------------------------------------------------------------
dolphin-emu.mk e8d9c124e5290c9c02c16d83583ce82b4e57c0f2 # Version: Commits on Oct 15, 2025
------------------------------------------------------------------------------------------
Merge pull request #13953 from TryTwo/add_osd_tab

Qt Settings: Transfer OSD settings to a new OSD pane.,

------------------------------------------------------------------------------------------
duckstation.mk 7deb374cf97f024df21a4d873d28ceb367bb2b78 # Version: Commits on Oct 16, 2025
------------------------------------------------------------------------------------------
Deps: Hopefully work around path length limits,

-----------------------------------------------------------------------------------
eden.mk b7021afff6c32cc832f891fbf07aedd92b6ddf76 # Version: Commits on Oct 16, 2025
-----------------------------------------------------------------------------------
[hid_core] Quick fix for PR 2747 (#2753)

--------------------------------------------------------------------------------------
flycast.mk 28ea3dc69c1859ac77ad3fa6fc16410b1b8f01e6 # Version: Commits on Oct 16, 2025
--------------------------------------------------------------------------------------
arcade: add CRC for all working roms. Fix mushik2k bios

All roms can now be loaded by CRC value.

Issue #1952

Fix mushik2k to use the multi-region hacked bios set to Korean region,

-------------------------------------------------------------------------------------
hatari.mk cfc0ae4b3ecec32ace42a2b65f27115cccbe72a9 # Version: Commits on Oct 15, 2025
-------------------------------------------------------------------------------------
Replace the SDL types with standard types in src/convert/

We're going to move this code out of the SDL scope soon, so make

sure that it compiles fine without the SDL headers.,

----------------------------------------------------
pcsx2.mk v2.5.229 # Version: Commits on Oct 16, 2025
----------------------------------------------------
- [Qt/BPM: Improve memory card shutdown warning messages for clarity ](PCSX2/pcsx2#13400)

,

-------------------------------------------------------------------------------------
ppsspp.mk 5aa0856280c2bcaf16db53ec82069b483a43eab0 # Version: Commits on Oct 16, 2025
-------------------------------------------------------------------------------------
Merge pull request #20878 from hrydgard/dx11-win7-fix

Add Windows version check before trying to even check for Win10-exclusive D3D features,

------------------------------------------------------------------------------------
rpcs3.mk 2fcd542b0b87b4d6012af31cc49f7a2f8015c06e # Version: Commits on Oct 15, 2025
------------------------------------------------------------------------------------
overlays: allow to update messages by id instead of text,

-----------------------------------------------------
ryujinx.mk 1.3.164 # Version: Commits on Oct 16, 2025
-----------------------------------------------------
Canary-1.3.164

-------------------------------------------------------------------------------------
snes9x.mk abfc018c90799eb55b773fc46d486167d8b3c762 # Version: Commits on Oct 16, 2025
-------------------------------------------------------------------------------------
vulkan: Fix a couple of new validation warnings.,

---------------------------------------------------
xemu.mk v0.8.108 # Version: Commits on Oct 16, 2025
---------------------------------------------------
,

-------------------------------------------------------------------------------------------
xenia-native.mk 7f359f36545c09d8e4f98582d83dfc4c304ee558 # Version: Commits on Oct 16, 2025
-------------------------------------------------------------------------------------------
[Kernel] Skip (again) initialization of XAM executable,

-----------------------------------------------------------------------------------
ymir.mk 2ef8a9aca179c638abb3d52eb7643bfe2dec068d # Version: Commits on Oct 16, 2025
-----------------------------------------------------------------------------------
feat(about): Update contributors list,

---------------------------------------------------------------
ruffle.mk nightly-2025-10-16 # Version: Commits on Oct 16, 2025
---------------------------------------------------------------
## What's Changed

* tests: Split up some giant files :D by @Dinnerbone in ruffle-rs/ruffle#21904

* tests: Add player version, currently unused by @Dinnerbone in ruffle-rs/ruffle#21931

* avm2: Fixes to Vector call handler by @Lord-McSweeney in ruffle-rs/ruffle#21926

* avm2: Fix edge cases in Math.pow by @kjarosh in ruffle-rs/ruffle#21933

**Full Changelog**: ruffle-rs/ruffle@nightly-2025-10-15...nightly-2025-10-16,

---------------------------------------------------------------------------------------
thextech.mk 6a9aa4cc514ce7fc7ff6e83b80629f159cff8167 # Version: Commits on Oct 16, 2025
---------------------------------------------------------------------------------------
CI: Switch from macos13 to macos-15-intel,

---------------------------------------------------------------------------------------
alephone.mk 613748bf83b756ddc9d47246ec94de8bd8ce6aa1 # Version: Commits on Oct 16, 2025
---------------------------------------------------------------------------------------
Simplify handlerPhysicsBuffer and allow it to be reused on map changes if no physics message is resent from the server/gatherer during the level transition,

------------------------------------------------------------------------------------
box64.mk 640e2b8bcf0a5b14c43a50b87df4d35620c7a4f5 # Version: Commits on Oct 16, 2025
------------------------------------------------------------------------------------
[BOX32] Enlarged xcb connects size again for Linux Steam (#3074),

---------------------------------------------------
nblood.mk r14297 # Version: Commits on Oct 16, 2025
---------------------------------------------------
,

-----------------------------------------------------------------------------------
raze.mk c5a79341bbbb8987230b9c7e8df415683b129901 # Version: Commits on Oct 16, 2025
-----------------------------------------------------------------------------------
- Express the `YAW_TURNSPEEDS[3]` constants mathematically also.

They're constexpr so there's no runtime calculation, etc.,

----------------------------------------------------------------------------------------
retroarch.mk 053ced8d1cbbe77dfa8c18f799a58fad37652db9 # Version: Commits on Oct 16, 2025
----------------------------------------------------------------------------------------
Fetch translations from Crowdin,

-------------------------------------------------------------------------------------
gzdoom.mk 0ce4de81c134fef5c2abe700aa88d80c377eabb8 # Version: Commits on Oct 12, 2025
-------------------------------------------------------------------------------------
Added support for massacre special 515 used by Heretic+Hexen's UMAPINFO definitions.,

-----------------------------------------------------------------------------------
tr1x.mk bf5cd537c024483af356bb50c659c3164323b60b # Version: Commits on Oct 16, 2025
-----------------------------------------------------------------------------------
data: update easter egg command

This injects Winston into TR1. His object setup requires a smartness

value to line up with TR1 pathfinding, so the maximum is applied

similar to other humans in TR1.,

-----------------------------------------------------------------------------------
tr2x.mk bf5cd537c024483af356bb50c659c3164323b60b # Version: Commits on Oct 16, 2025
-----------------------------------------------------------------------------------
data: update easter egg command

This injects Winston into TR1. His object setup requires a smartness

value to line up with TR1 pathfinding, so the maximum is applied

similar to other humans in TR1.,

------------------------------------------------------------------------------------------
xash3d-fwgs.mk a7b466e4a9b71735f234d30952cf3d4a792da646 # Version: Commits on Feb 05, 2025
------------------------------------------------------------------------------------------
scripts: gha: try to update vitaGL,

-----------------------------------------------------------------------------------------------
libretro-bennugd.mk 8f54684f18d6e3d557fe6c5c89002fe94022e98a # Version: Commits on Oct 15, 2025
-----------------------------------------------------------------------------------------------
Add badges and format BennuGD description,

-----------------------------------------------------------------------------------------------
libretro-dolphin.mk bfac84ab609696a96a24261fd3bb5f12e90c2409 # Version: Commits on Oct 16, 2025
-----------------------------------------------------------------------------------------------
Only check for JIT capable on tvOS/iOS/iPadOS,

-----------------------------------------------------------------------------------------------
libretro-flycast.mk 28ea3dc69c1859ac77ad3fa6fc16410b1b8f01e6 # Version: Commits on Oct 16, 2025
-----------------------------------------------------------------------------------------------
arcade: add CRC for all working roms. Fix mushik2k bios

All roms can now be loaded by CRC value.

Issue #1952

Fix mushik2k to use the multi-region hacked bios set to Korean region,

------------------------------------------------------------------------------------------------
libretro-nestopia.mk e9429844f2e16a284a8cdf663589634fd4c6345f # Version: Commits on Oct 16, 2025
------------------------------------------------------------------------------------------------
Libretro: Refactor check_variables() in libretro.cpp with core option reordering (#106)

* Libretro: Sort options in check_variables() based on category/order

* Libretro: Add comments with core option names in check_variables()

* Libretro: Minor style adjustments to overscan variables,

----------------------------------------------------------------------------------------------
libretro-ppsspp.mk 5aa0856280c2bcaf16db53ec82069b483a43eab0 # Version: Commits on Oct 16, 2025
----------------------------------------------------------------------------------------------
Merge pull request #20878 from hrydgard/dx11-win7-fix

Add Windows version check before trying to even check for Win10-exclusive D3D features,

-----------------------------------------------------------------------------------------------
libretro-sameboy.mk 10801af8e3d633bbc097b7ca8e6a9994c32b33d4 # Version: Commits on Oct 15, 2025
-----------------------------------------------------------------------------------------------
Fix PCM34 read accuracy on CGB-C and older,

---------------------------------------------------------------------------------------------
libretro-vba-m.mk 5b91f694fd9165c7c74db8caf8413bfce9cd2aca # Version: Commits on Oct 16, 2025
---------------------------------------------------------------------------------------------
build: add SDK inc to CXXFLAGS for Mac builder

Add the macOS SDK header paths to `CXXFLAGS` for the Mac builder because

of errors caused by these shits breaking my headers.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>,

--------------------------------------------------------------------------------------------
slang-shaders.mk dc4e8b01a378f922a8558c7151bae228aa8107f1 # Version: Commits on Oct 16, 2025
--------------------------------------------------------------------------------------------
Update crt-consumer-1w (#754)

* Update ntsc_module.slang

* Update crt-consumer-1w.slang

* Update crt-pocket.slang,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Set default selection to "No" when closing while memory card is busy

2 participants