Qt: Make mouse screen locking DPI aware and support render to separate window#13403
Merged
Qt: Make mouse screen locking DPI aware and support render to separate window#13403
Conversation
Member
Author
|
Added support for "render to separate window". @chaoticgd tested x11 and found that one axis did not clamp properly on a non-100 DPI but I could not reproduce it here. |
Also removed some global mouse hook stuff. Don't ever want to use that anyways.
F0bes
force-pushed
the
mouselocking-dpi-aware
branch
from
4341583 to
a875fdd
Compare
F0bes
changed the title
Member
Author
The issue happens when
I don't think there is much I can or want to do about that right now, so I've gone ahead and added a warning in the options description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
When the feature was developed, I didn't think about how
QWindow::geometry()might not be scaled to the current DPI.I now scale the window geometry to the current monitors pixel scale, and then clamp.
I also made the function safer, as I was assuming a fixed size of data from GetRawInputData, and I wasn't checking if
GetCursorPoswas successful or not before using its result.Also removed some unused global mouse hook stuff. Don't ever want to use that anyways.
Also implemented support for 'render to separate window'
Rationale behind Changes
Fixes #12695
Suggested Testing Steps
Test different DPIs
Did you use AI to help find, test, or implement this issue or feature?
yeah, copilot auto complete