EE JIT: Fix LUT weirdness #13684
Open
EE JIT: Fix LUT weirdness #13684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Tries to make the LUT allocation/sizing easier to understand.
Rationale behind Changes
I was comparing the EE and IOP JIT's and couldn't understand why the EE JIT was dividing by the host pointer size in ClearRecLut, I think it must be a mistake. The division by four was to meant to divide an EE memory range into the number of possible call targets.
Suggested Testing Steps
Any game that dynamically loads code, Jak series, SOTC are some I know of.
Did you use AI to help find, test, or implement this issue or feature?
No