Deps: Dont include GTK when building Qt #13710
Open
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamfretoz
force-pushed
the
be-gone-gtk3
branch
from
0f0176d to
d2c05fa
Compare
kamfretoz
force-pushed
the
be-gone-gtk3
branch
from
d2c05fa to
24a33f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR disables GTK features when building Qt. It has been causing issue with our self-built ffmpeg on AppImage and seemingly causes crashes on GNOME as well. It looks like we don't need it on PCSX2 (preliminary testing by @Mrlinkwii shows no breakage on GNOME) plus it shaves off around ~6MB from the AppImage binary size.
Relevant issue: #13008
Rationale behind Changes
Trimming the cruft.
Suggested Testing Steps
Test PCSX2's Qt functionality on GNOME/GTK based distros (Ubuntu, Linux Mint, etc).
Did you use AI to help find, test, or implement this issue or feature?
No.