DiscordRPC: Simplify Game Icon Retrieval #13749
Open
+7
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamfretoz
force-pushed
the
rpc-icon-improvement
branch
from
9869fc4 to
1964b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Simplify how we retrieve the rcheevos set image. Previously we have to get the URL manually by using
rc_client_game_get_image_urlsincerc_client_get_game_infodoes not provide the URL by default.#12940 rcheevos v12.0.0 added
badge_urlentry torc_client_get_game_infowhich means we can use it instead of having to grab the URL on our own manually.Rationale behind Changes
Simplification
Suggested Testing Steps
Just run a game which has an achievement set + rich presence support and see if the icon shows up properly.
I've already tested locally and they still work.
Did you use AI to help find, test, or implement this issue or feature?
Gak