GS: Add GPU pipeline stats to OSD.#14381
Open
TJnotJT wants to merge 5 commits intoPCSX2:masterfrom
Open
Conversation
Adds vertex shader and pixel shader invocations.
17bf328 to
f20fb37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds vertex shader and pixel shader invocations to the OSD.
Rationale behind Changes
Add additional informations for diagnosing performance issues.
Suggested Testing Steps
Use any HW renderer and enable 'Show GPU Pipeline Statistics' in Settings>On-Screen Display. The OSD should show a line like
for the vertex shader invocations and pixel shader invocations (suffixes: K = 10^3, M = 10^6, B = 10^9).
The value of pixel shader invocations varies dramatically between the APIs, and likely can't be compared meaningfully. (I don't currently have a good explanation for the cause.)Edit: changed the behavior so that it collects stats before OSD/ImGui is drawn. The results seem more stable and it could be a reasonable comparison.The values also show for SW since it uses VK for presenting, but the values are likely not meaningful.
Did you use AI to help find, test, or implement this issue or feature?
Yes, to ask about how pipeline stats queries work in the APIs.