CDVD: validate CSO frame and index sizes - #14753
Open
acts-1631 wants to merge 1 commit into
Open
Conversation
CSO headers can specify an oversized frame size or index alignment, allowing a compressed frame index to make fread exceed the allocated read buffer. Limit supported frame and alignment values and reject compressed frame sizes that exceed the allocated buffer.
Contributor
|
Fill out the PR Template. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
Author
|
Working with a broken wrist rn so typing ability is limited. I'll update both later on if you keep them open. Sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate CSO header bounds and compressed frame lengths.
A crafted CSO/ZSO could make a compressed-frame read exceed its allocated buffer during image detection. The reader now rejects unsupported frame and alignment sizes, and rejects oversized compressed frame spans.