Patch: Clean up PatchCommand struct - #14789
Open
chaoticgd wants to merge 1 commit into
Open
Conversation
chaoticgd
force-pushed
the
patch_command_ub
branch
from
July 29, 2026 13:18
dbb3012 to
a9f945e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Clean up the PatchCommand struct.
Rationale behind Changes
The trick it was previously using where you memset/memcmp the whole struct isn't valid, since the compiler is allowed to overwrite padding when combining writes. In practice clang seems to be conservative about this, but we shouldn't be relying on it.
Suggested Testing Steps
Make sure
bytespatches still work as expected.Did you use AI to help find, test, or implement this issue or feature?
No.