Fix compilation with newer versions of PDAL#59
Closed
dvdkon wants to merge 1 commit into
Closed
Conversation
Member
@abellgithub is going to update PDAL 2.9 so it no longer has any nlohmann in public headers. PDAL has embedded nlohmann for more than 10 years without issue. The problem is it changed its type definition instead of adding extended new ones. For little benefit, I might add. |
Author
|
Closing since PDAL master has fixed the issue of leaking JSON definitions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently building
pdal_wrenchis broken when using PDAL frommaster(28e77b0608795c087bf2ca8ff0906d2d22270bd5). This PR "fixes" the build by moving around includes, as suggested by PDAL/PDAL#4706 (comment).This is also needed to fix QGIS: qgis/QGIS#61670
Personally, I think we should stop embedding
nlohmann/jsoneverywhere, but that's for later discussion.