Skip to content

Fix issues #60

Merged
wonder-sk merged 15 commits into
PDAL:mainfrom
JanCaha:fix-merge-to-copc
Jul 1, 2025
Merged

Fix issues #60
wonder-sk merged 15 commits into
PDAL:mainfrom
JanCaha:fix-merge-to-copc

Conversation

@JanCaha

@JanCaha JanCaha commented Jun 27, 2025

Copy link
Copy Markdown
Collaborator

Fixes several slight related issues:

  • main issue was in merge which did not run if the output was copc.laz that also caused issue in other tools as some of them use Merge as last step
  • for VPC there as an issue if the files in VPC were .copc.laz where the extensions were not stripped correctly for this the fs::path fileStem(const std::string &filename) was introduced which should only return stem of file without any extensions - this avoids potentialy creating files with .copc.las extension that cannot be read properly by PDAL
  • tests that looked really similary were parametrized and some test cases were added (mostly with input with VPC containing .copc.laz files and output of algs to .copc.laz)

Fixes qgis/QGIS#62415 and possibly similar issues

Comment thread tests/conftest.py Outdated
Comment thread tests/conftest.py Outdated
Comment thread src/merge.cpp
Comment thread tests/test_clip.py Outdated
@wonder-sk wonder-sk merged commit 1a3c90c into PDAL:main Jul 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pdal:clip (and other pdal-Tools) does not work when Input is a vpc (containing *.copc.laz) and Output is a temporary output file or a vpc or copc.laz

2 participants