Conversation
There was a problem hiding this comment.
Pull Request Overview
Dropping support for Python 3.8 by raising the minimum Python version requirement and updating related documentation and CI.
- Bump project’s
requires-pythonfrom>=3.8to>=3.9 - Update install instructions in README to require Python 3.9+
- Remove Python 3.8 from GitHub Actions lint-and-fmt workflow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Updated requires-python to >=3.9 and inlined the dev list |
| README.md | Adjusted installation note to Python 3.9+ |
| .github/workflows/lint-and-fmt.yml | Changed CI matrix to only run on Python 3.9 |
Comments suppressed due to low confidence (3)
.github/workflows/lint-and-fmt.yml:15
- The CI matrix currently only tests on Python 3.9; consider adding newer supported versions (e.g., 3.10, 3.11) to ensure compatibility across all maintained Python releases.
python-version: ["3.9"]
pyproject.toml:16
- [nitpick] Consider preserving the original multi-line formatting for the
devdependency group to improve readability and consistency when adding more dev dependencies in the future.
dev = ["hatchling>=1.27.0"]
Contributor
Author
|
看起来应该 follow 一下 0.17.0、0.17.1、0.17.2 了 https://github.com/google/yamlfmt/releases @gouzil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
不再支持 Python 3.8