♻️ refactor: use build replace download and add musllinux_1_2_i686、musllinux_1_2_armv7l#17
Merged
gouzil merged 19 commits intoPFCCLab:mainfrom Jul 5, 2025
Merged
Conversation
…and `musllinux_1_2_armv7l`
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the build process to compile yamlfmt from source instead of downloading prebuilt archives, adds new integration tests, and extends platform support with two additional musllinux architectures.
- Replace binary download with a Go-based build in
hatch_build.py - Extend
BUILD_TARGET, CIrelease-buildmatrix to includemusllinux_1_2_i686andmusllinux_1_2_armv7l - Add cross-platform test suite and update GitHub Actions workflow
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_yamlfmt.py | New integration tests for CLI version, formatting, help, import, etc. |
| tests/test_input.yaml | Sample YAML file for formatting tests (not yet referenced) |
| tests/README.md | Documentation of test suite |
| hatch_build.py | Switched from download hook to source build hook; updated mappings |
| .github/workflows/release.yaml | Added test job and updated release-build matrix for new arches |
Comments suppressed due to low confidence (3)
.github/workflows/release.yaml:18
- The test job matrix does not include the newly added musllinux_1_2 i686 and armv7l architectures, so those platforms are not covered by CI tests; consider adding entries for these in the test matrix.
- {"runner": "macos-latest", "platform_tag": "macosx_11_0", "arch": "arm64"}
tests/test_input.yaml:1
- The new sample YAML input file is not used by any test; add a corresponding test to validate formatting using this file or remove the unused file.
# Test YAML file for yamlfmt testing
tests/README.md:40
- The README mentions a test for executable permissions, but no such test is present in the suite; either remove this item or add the corresponding test.
4. **Executable Permissions**: Verifies the yamlfmt executable has correct permissions
SigureMo
reviewed
Jul 5, 2025
Collaborator
Author
|
不正常,让我修一修 |
Contributor
|
等会是不是可以发俩新的 release 了 |
Collaborator
Author
是的 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor
go build代替原来的 download zipfeat
musllinux_1_2_i686、musllinux_1_2_armv7l两种架构uv build了,不需要再加 envTODO
pip install -e .