Skip to content

♻️ refactor: use build replace download and add musllinux_1_2_i686musllinux_1_2_armv7l#17

Merged
gouzil merged 19 commits intoPFCCLab:mainfrom
gouzil:feat/use_build
Jul 5, 2025
Merged

♻️ refactor: use build replace download and add musllinux_1_2_i686musllinux_1_2_armv7l#17
gouzil merged 19 commits intoPFCCLab:mainfrom
gouzil:feat/use_build

Conversation

@gouzil
Copy link
Collaborator

@gouzil gouzil commented Jul 2, 2025

refactor

  • 使用 go build 代替原来的 download zip
  • 添加单测

feat

  • 增加了musllinux_1_2_i686musllinux_1_2_armv7l 两种架构
  • 现在可以直接使用 uv build 了,不需要再加 env

TODO

  • 已知问题,不能使用 pip install -e .

@gouzil gouzil requested a review from Copilot July 2, 2025 15:16

This comment was marked as outdated.

@gouzil gouzil requested a review from Copilot July 5, 2025 04:51

This comment was marked as outdated.

@gouzil gouzil requested a review from Copilot July 5, 2025 05:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the build process to compile yamlfmt from source instead of downloading prebuilt archives, adds new integration tests, and extends platform support with two additional musllinux architectures.

  • Replace binary download with a Go-based build in hatch_build.py
  • Extend BUILD_TARGET, CI release-build matrix to include musllinux_1_2_i686 and musllinux_1_2_armv7l
  • Add cross-platform test suite and update GitHub Actions workflow

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_yamlfmt.py New integration tests for CLI version, formatting, help, import, etc.
tests/test_input.yaml Sample YAML file for formatting tests (not yet referenced)
tests/README.md Documentation of test suite
hatch_build.py Switched from download hook to source build hook; updated mappings
.github/workflows/release.yaml Added test job and updated release-build matrix for new arches
Comments suppressed due to low confidence (3)

.github/workflows/release.yaml:18

  • The test job matrix does not include the newly added musllinux_1_2 i686 and armv7l architectures, so those platforms are not covered by CI tests; consider adding entries for these in the test matrix.
          - {"runner": "macos-latest", "platform_tag": "macosx_11_0", "arch": "arm64"}

tests/test_input.yaml:1

  • The new sample YAML input file is not used by any test; add a corresponding test to validate formatting using this file or remove the unused file.
# Test YAML file for yamlfmt testing

tests/README.md:40

  • The README mentions a test for executable permissions, but no such test is present in the suite; either remove this item or add the corresponding test.
4. **Executable Permissions**: Verifies the yamlfmt executable has correct permissions

@gouzil gouzil requested a review from SigureMo July 5, 2025 08:45
Copy link
Contributor

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gouzil
Copy link
Collaborator Author

gouzil commented Jul 5, 2025

Release / test (windows-latest) (pull_request) 挂了是正常的么

不正常,让我修一修

Copy link
Contributor

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo
Copy link
Contributor

SigureMo commented Jul 5, 2025

等会是不是可以发俩新的 release 了

@gouzil
Copy link
Collaborator Author

gouzil commented Jul 5, 2025

等会是不是可以发俩新的 release 了

是的

@gouzil gouzil merged commit ba5a366 into PFCCLab:main Jul 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants