Skip to content

🐛 fix: stop run CI in forked repo#20

Merged
SigureMo merged 2 commits intoPFCCLab:mainfrom
gouzil:fix/ci_run_repo
Jul 5, 2025
Merged

🐛 fix: stop run CI in forked repo#20
SigureMo merged 2 commits intoPFCCLab:mainfrom
gouzil:fix/ci_run_repo

Conversation

@gouzil
Copy link
Collaborator

@gouzil gouzil commented Jul 5, 2025

fix

  • ci 在 fork repo 上运行

@gouzil gouzil requested review from SigureMo and Copilot July 5, 2025 13:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to ensure CI jobs run only in the main repository and removes the uv.lock file.

  • Adds a repository check to the lint-and-fmt workflow
  • Deletes the uv.lock file
Comments suppressed due to low confidence (1)

.github/workflows/lint-and-fmt.yml:12

  • This if condition restricts the job to the main repo, which prevents CI from running on forks. To enable CI in forked repositories, consider removing this condition or adjusting it to detect and allow forks explicitly.
    if: github.repository == 'PFCCLab/google-yamlfmt'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要删掉 lockfile?一般 lockfile 是需要存在 repo 里的,确保可复现性

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

行,我考虑的是,因为编译产物并不会在这里,所以这个可复现是不稳定的。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里主要是编译依赖吧,主要能保证 CI 编译环境能一致

@SigureMo
Copy link
Contributor

SigureMo commented Jul 5, 2025

标题里应该是 stop run CI in forked repo

@gouzil gouzil changed the title 🐛 fix: ci run in fork repo 🐛 fix: stop run CI in forked repo Jul 5, 2025
@SigureMo SigureMo merged commit 25397fd into PFCCLab:main Jul 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants