🐛 fix: stop run CI in forked repo#20
Merged
SigureMo merged 2 commits intoPFCCLab:mainfrom Jul 5, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to ensure CI jobs run only in the main repository and removes the uv.lock file.
- Adds a repository check to the lint-and-fmt workflow
- Deletes the
uv.lockfile
Comments suppressed due to low confidence (1)
.github/workflows/lint-and-fmt.yml:12
- This
ifcondition restricts the job to the main repo, which prevents CI from running on forks. To enable CI in forked repositories, consider removing this condition or adjusting it to detect and allow forks explicitly.
if: github.repository == 'PFCCLab/google-yamlfmt'
SigureMo
reviewed
Jul 5, 2025
Contributor
There was a problem hiding this comment.
为什么要删掉 lockfile?一般 lockfile 是需要存在 repo 里的,确保可复现性
Collaborator
Author
There was a problem hiding this comment.
行,我考虑的是,因为编译产物并不会在这里,所以这个可复现是不稳定的。
Contributor
There was a problem hiding this comment.
这里主要是编译依赖吧,主要能保证 CI 编译环境能一致
Contributor
|
标题里应该是 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix