Skip to content

🐛 fix: GLIBC version too low and linux default platform #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SigureMo merged 1 commit into from
Jul 16, 2025
Merged

🐛 fix: GLIBC version too low and linux default platform #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions hatch_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
from hatchling.builders.hooks.plugin.interface import BuildHookInterface

PY_PLATFORM_MAPPING = {
("Linux", "x86_64"): ("musllinux_1_2", "x86_64"),
("Linux", "i686"): ("musllinux_1_2", "i686"),
("Linux", "armv7l"): ("musllinux_1_2", "armv7l"),
("Linux", "aarch64"): ("musllinux_1_2", "aarch64"),
("Linux", "x86_64"): ("manylinux_2_17", "x86_64"),
("Linux", "i686"): ("manylinux_2_17", "i686"),
("Linux", "armv7l"): ("manylinux_2_17", "armv7l"),
("Linux", "aarch64"): ("manylinux_2_17", "aarch64"),
("Darwin", "x86_64"): ("macosx_10_12", "x86_64"),
("Darwin", "arm64"): ("macosx_11_0", "arm64"),
("Windows", "AMD64"): ("win", "amd64"),
Expand Down Expand Up @@ -84,7 +84,7 @@ def initialize(self, version: str, build_data: dict[str, Any]) -> None:
def build_yamlfmt(self, target_os_info: str, target_arch: str) -> None:
"""Build the yamlfmt binary for the specified OS and architecture."""
# 确认环境安装
for command in ["go", "make", "git"]:
for command in ["go", "git"]:
assert shutil.which(command), f"{command} is not installed or not found in PATH"

build_target = BUILD_TARGET[(target_os_info, target_arch)]
Expand All @@ -108,10 +108,18 @@ def build_yamlfmt(self, target_os_info: str, target_arch: str) -> None:
],
check=True,
)
# 获取最新的提交哈希
commit_hash = subprocess.run(
["git", "rev-parse", "--short", "HEAD"],
cwd=self.temp_dir / f"yamlfmt-{version}",
capture_output=True,
text=True,
check=True,
).stdout.strip()

# 编译
env = os.environ.copy()
env.update({"GOOS": build_target[0], "GOARCH": build_target[1]})
env.update({"GOOS": build_target[0], "GOARCH": build_target[1], "CGO_ENABLED": "0"})
if target_arch == "armv7l":
env.update({"GOARM": "7"})

Expand All @@ -120,7 +128,15 @@ def build_yamlfmt(self, target_os_info: str, target_arch: str) -> None:
assert work_dir.exists(), f"Working directory {work_dir} does not exist"

subprocess.run(
["make", "build"],
[
"go",
"build",
"-ldflags",
f"-s -w -X 'main.version={version}' -X 'main.commit={commit_hash}'",
Copy link

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The single quotes around main.version and main.commit in the -X flags will be passed literally to the Go linker. Either remove the inner quotes or split the flags into separate arguments (e.g., -X, main.version=...) so the linker receives -X main.version=... correctly.

Suggested change
f"-s -w -X 'main.version={version}' -X 'main.commit={commit_hash}'",
f"-s -w -X main.version={version} -X main.commit={commit_hash}",

Copilot uses AI. Check for mistakes.
"-o",
f"dist/{self.BIN_NAME}",
"./cmd/yamlfmt",
],
env=env,
cwd=work_dir,
capture_output=True,
Expand Down
Loading