Second-order AMR: higher-order field refinement + coarse–fine temporal fixes - #1278
Draft
UCaromel wants to merge 23 commits into
Draft
Second-order AMR: higher-order field refinement + coarse–fine temporal fixes#1278UCaromel wants to merge 23 commits into
UCaromel wants to merge 23 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AMR on
masteris not second-order accurate. The field refinement (coarse→fine spatial interpolation) and the coarse–fine time interpolation are only first-order, so an AMR run does not recover the scheme's second-order accuracy near refinement boundaries — accuracy is effectively capped below 2nd order wherever levels exist.This PR makes AMR genuinely second-order in both space and time:
The existing first-order (legacy) refinement path is kept. Flipping the default and/or removing the legacy path is a team decision; for now both coexist and are selectable at runtime, so this PR changes no default behaviour.
How
Selectable from the Python config via the refinement order (and limiter); legacy = order 0.
Validation
2D AMR spatial convergence (composite L2-of-L1 norm, MC2011). With
refinement_order=2, both alfven2d and whistler2d converge at slope 2, inside the calibrated gate band (1.70, 2.25):