Skip to content

rm datawrangler/etc #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PhilipDeegan
Copy link
Member

unused, not maintained code.

Copy link

coderabbitai bot commented Mar 6, 2025

📝 Walkthrough

Walkthrough

The pull request modifies several Python binding files by removing several header inclusions and functions that expose patch data and data management functionalities. In the C++ simulator source, an include for meta utilities has been added, and calls to register patch data have been removed. In the header file, unused includes and a template function were eliminated, and some function signatures were updated. Additionally, files associated with data wrangling, patch data, and patch level have been deleted, and minor modifications were made to the Python binding definition file.

Changes

Files Change Summary
src/python3/cpp_simulator.cpp - Added #include "core/utilities/meta/meta_utilities.hpp"
- Removed namespace py = pybind11; alias
- Deleted three declarePatchData function calls (1D, 2D, 3D) from the module initialization
src/python3/cpp_simulator.hpp - Removed multiple header includes and the declarePatchData template function
- Modified declare_essential function signature to inline
- Adjusted variable declaration in declare_etc
- Removed code related to DataWrangler and PatchLevel
src/python3/(data_wrangler.hpp, patch_data.hpp, patch_level.hpp) - Deleted the file data_wrangler.hpp (removed definitions for DataWrangler and SimulatorCaster)
- Deleted the file patch_data.hpp (removed the PatchData structure and associated functions)
- Deleted the file patch_level.hpp (removed the PatchLevel class)
src/python3/pybind_def.hpp - Removed the include directives for <stdexcept> and "pybind11/stl.h"
pyphare/pyphare/pharesee/hierarchy/__init__.py - Removed import for hierarchy_from_sim and related conditional logic in hierarchy_from function
pyphare/pyphare/pharesee/hierarchy/fromsim.py - Deleted file containing hierarchy_from_sim function, which constructed hierarchical simulation data
pyphare/pyphare/simulator/simulator.py - Removed data_wrangler method and associated cpp_dw attribute from Simulator class
src/python3/cpp_etc.cpp - Reordered include directives without functional changes
tests/simulator/CMakeLists.txt - Removed lines executing data_wrangler.py and refined_particle_nbr.py scripts from test configuration
tests/simulator/(data_wrangler.py, refined_particle_nbr.py) - Deleted files containing unit tests for DataWrangler and SimulatorRefinedParticleNbr classes

Sequence Diagram(s)

sequenceDiagram
    participant Py as Python Interpreter
    participant Mod as cpp_simulator Module
    Py->>Mod: Import module
    Note over Mod: Module initialization starts
    Mod-->>Mod: Include meta_utilities.hpp
    Note over Mod: Removed patch data registration calls
    Mod-->>Py: Module initialized without patch data
Loading

Suggested labels

refactoring, feature, test, python

Suggested reviewers

  • nicolasaunai
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]

This comment was marked as off-topic.

Copy link
Member

@nicolasaunai nicolasaunai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants