-
Notifications
You must be signed in to change notification settings - Fork 26
rm datawrangler/etc #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
rm datawrangler/etc #968
Conversation
📝 WalkthroughWalkthroughThe pull request modifies several Python binding files by removing several header inclusions and functions that expose patch data and data management functionalities. In the C++ simulator source, an include for meta utilities has been added, and calls to register patch data have been removed. In the header file, unused includes and a template function were eliminated, and some function signatures were updated. Additionally, files associated with data wrangling, patch data, and patch level have been deleted, and minor modifications were made to the Python binding definition file. Changes
Sequence Diagram(s)sequenceDiagram
participant Py as Python Interpreter
participant Mod as cpp_simulator Module
Py->>Mod: Import module
Note over Mod: Module initialization starts
Mod-->>Mod: Include meta_utilities.hpp
Note over Mod: Removed patch data registration calls
Mod-->>Py: Module initialized without patch data
Suggested labels
Suggested reviewers
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gtm
unused, not maintained code.