Skip to content

Comments

don't show jwt secret if show option is false even if the key is updated#275

Merged
Messhias merged 1 commit intoPHP-Open-Source-Saver:mainfrom
kbiits:main
Jan 25, 2025
Merged

don't show jwt secret if show option is false even if the key is updated#275
Messhias merged 1 commit intoPHP-Open-Source-Saver:mainfrom
kbiits:main

Conversation

@kbiits
Copy link
Contributor

@kbiits kbiits commented Jan 7, 2025

Description

Fixes #274
Adding a new option in jwt secret generator command for not showing the newly generated key.

Checklist:

  • I've added tests for my changes or tests are not applicable
  • I've changed documentations or changes are not required
  • I've added my changes to CHANGELOG.md

Copy link
Contributor

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


Confusingly, ->displayKey() also did this:

$this->laravel['config']['jwt.secret'] = $key;

Apparently for not much reason I believe though.

@Messhias Messhias merged commit 873de1f into PHP-Open-Source-Saver:main Jan 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate Secret Command - add option to not showing the key if it's updated

3 participants