Skip to content

Update lcobucci/jwt library to support php 8.4 #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

NetoBraghetto
Copy link
Contributor

@NetoBraghetto NetoBraghetto commented Feb 25, 2025

Update dependency lcobuccijwt from 5.0 to 5.4 to support PHP 8.4

Description

Since there is no relevant changes in release 5.4 PR

Checklist:

  • I've added tests for my changes or tests are not applicable
  • I've changed documentations or changes are not required
  • I've added my changes to CHANGELOG.md

@specialtactics
Copy link
Member

Technically it already supports it, this just raises the minimum to the 8.4 version, but it shouldn't block anyone from using this package with 8.4, in fact we have CI testing that proves this.

But anyway, there's no issue with increasing the minimum.

Copy link
Contributor

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, technically the change is not necessary as composer will pick the right version.

But it also does no harm, the important part is that the minimum php version of jwt-auth matches the 5.4 php minimum brtdion.

I'm mentioning this to make sure people making the PRs don't wrongly assume it's necessary, it isn't.

@Messhias Messhias merged commit 54116ef into PHP-Open-Source-Saver:main Feb 26, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants