Skip to content

Fixed the return type of getMinutesUntilExpired in BlackList, which returned a float instead of an int when using Carbon v2. #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

jonkerw85
Copy link
Contributor

Description

Fixed the return type of getMinutesUntilExpired in BlackList, which returned a float instead of an int when using Carbon v2.

Checklist:

  • [✖] I've added tests for my changes or tests are not applicable
  • [✔] I've changed documentations or changes are not required
  • [ ✔] I've added my changes to CHANGELOG.md

getMinutesUntilExpired should always return int
@mfn
Copy link
Contributor

mfn commented Feb 27, 2025

I think, in general, we should just remove Carbon 2 anyway:

  • L10 is out of support already (which only support 2)
  • L11 supports both
  • L12 only 3

@specialtactics
Copy link
Member

specialtactics commented Feb 28, 2025

I agree with your point of view @mfn - I guess the only issue is, there will still be some people running on 10, and 12 has only just need released, so it would be better to provide them with ongoing support and new features, until they upgrade. This is probably another discussion, I agree we should drop support for Laravel 10, but at a later date in the year, maybe middle of the year. I will raise another issue about it to discuss.

Meanwhile, this PR is perfectly fine to merge and tag as patch, so I will do that. Tagged as 2.8.1

PS. Please vote here on the topic of laravel 10 support - #287

@specialtactics specialtactics merged commit cd55a88 into PHP-Open-Source-Saver:main Feb 28, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants