Conversation
Addresses some of the action points listed in PHPCSStandards/PHP_CodeSniffer 1392
* Highlight (bold) PHP extension names * Force a few long bullet points to display as multiple lines.
|
=== This is an auto-generated comment === Thank you for your PR. Please review the resulting final markdown files via the created artifact. N.B.: the above link will automatically be updated when this PR is updated. |
16 tasks
Contributor
rodrigoprimo
left a comment
rodrigoprimo
left a comment
There was a problem hiding this comment.
Thanks, @jrfnl. Looks good to me overall. I left two non-blocking comments for us to discuss.
fredden
approved these changes
Mar 20, 2026
rodrigoprimo
approved these changes
Mar 23, 2026
Contributor
rodrigoprimo
left a comment
rodrigoprimo
left a comment
There was a problem hiding this comment.
Thanks for updating the text about the iconv requirement for a few of the reports, @jrfnl. This PR looks good to me now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up on #91 and #95.
Wiki/Requirements: add links to the docs for each PHP extension
Wiki/Requirements: add information on additional PHP extensions
Addresses some of the action points listed in PHPCSStandards/PHP_CodeSniffer#1392
Wiki/Requirements: add more info about recommendations and links to other wiki docs
Wiki/Requirements: improve readability
Related issues/external references