Skip to content

PEAR/Squiz/InlineComment: document handling of emoji hash comments #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Standards/PEAR/Tests/Commenting/InlineCommentUnitTest.inc
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,5 @@ function test()
### use the code from the regex
### over hre
### ok?

#️⃣ Apparently the emoji keycap number sign (hash) also works and turns this into a comment.
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,5 @@ function test()
// use the code from the regex
// over hre
// ok?

// ️⃣ Apparently the emoji keycap number sign (hash) also works and turns this into a comment.
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public function getErrorList()
27 => 1,
28 => 1,
29 => 1,
31 => 1,
];

}//end getErrorList()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@ readonly class MyClass
readonly $property = 10;
}

#️⃣ Apparently the emoji keycap number sign (hash) also works and turns this into a comment.
echo 'hello!';

/*
* N.B.: The below test line must be the last test in the file.
* Testing that a new line after an inline comment when it's the last non-whitespace
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,9 @@ readonly class MyClass
readonly $property = 10;
}

// ️⃣ Apparently the emoji keycap number sign (hash) also works and turns this into a comment.
echo 'hello!';

/*
* N.B.: The below test line must be the last test in the file.
* Testing that a new line after an inline comment when it's the last non-whitespace
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public function getErrorList($testFile='')
126 => 2,
130 => 2,
149 => 1,
189 => 1,
];

return $errors;
Expand Down