Generators/[HTML|Markdown|Text]::getFormattedCodeComparisonBlock(): minor refactor #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move some duplicate code to dedicated `private` methods.
Move some duplicate code to dedicated `private` methods.
Move some duplicate code to dedicated `private` methods.
There's absolutely no need for custom word-wrapping logic when PHP contains a function which can do this perfectly well.
Move yet more duplicate code to a dedicated `private` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These five commits basically apply the same changes to all three Generator classes (reduce code duplication), which is why I've combined them in one PR.
Generators/HTML::getFormattedCodeComparisonBlock(): minor refactor
Move some duplicate code to dedicated
privatemethods.Generators/Markdown::getFormattedCodeComparisonBlock(): minor refactor
Move some duplicate code to dedicated
privatemethods.Generators/Text::getFormattedCodeComparisonBlock(): minor refactor [1]
Move some duplicate code to dedicated
privatemethods.Generators/Text::codeTitleToLines(): simplify the logic
There's absolutely no need for custom word-wrapping logic when PHP contains a function which can do this perfectly well.
Generators/Text::getFormattedCodeComparisonBlock(): minor refactor [2]
Move yet more duplicate code to a dedicated
privatemethod.Suggested changelog entry
N/A
Related issues/external references
This PR is part of a series of PRs which will add a complete set of tests (and improvements) for the Generator feature.
Also see: #671 and other PRs with the Core Component: Generators label.