-
-
Notifications
You must be signed in to change notification settings - Fork 76
PHP 8.4 | Add tokenization of asymmetric visibility #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jrfnl
merged 20 commits into
PHPCSStandards:master
from
DanielEScherzer:asymmetric-visibility-tokens
May 10, 2025
+684
−43
Merged
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
986d4ef
PHP 8.4 | Add tokenization of asymmetric visibility
DanielEScherzer b3e4816
Drop typehints
DanielEScherzer bd3aa78
Asymmetric visibility: expand tests, check is_array
DanielEScherzer baa8fc2
=== true
DanielEScherzer c8fdc9a
2 more fixes
DanielEScherzer d90084a
Expand and improve tests
DanielEScherzer 6c24745
PHPCS fixes
DanielEScherzer dc928ee
Add tests for existing sniffs
DanielEScherzer 7d792ca
Asymmetric visibility not yet in member properties
DanielEScherzer 49512e6
Nullable tests
DanielEScherzer 387063d
Nullable fix
DanielEScherzer 01077e3
Accidental change reverted
DanielEScherzer 1b5eacb
TokenNameTest: add new tokens
jrfnl 3bc7291
BackfillAsymmetricVisibilityTest: various small tweaks
jrfnl 78d1645
Tokens::$contextSensitiveKeywords: remove asym keywords
jrfnl c08f84e
NullableVsInlineThenTest: minor tweaks
jrfnl 47b2589
PSR12/ConstantVisibility: remove tests which wouldn't trigger the sniff
jrfnl bd1b0d6
PSR12/ConstantVisibility: rename test case file
jrfnl b010b6a
PSR12/ConstantVisibility: prevent false negatives for asym visibility
jrfnl 0a4dd1c
CS fix
jrfnl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.