Support recursive ** glob patterns via globstar - #42
Closed
AnHeuermann wants to merge 1 commit into
Closed
Conversation
The `pattern` input was expanded with unquoted bash pathname expansion without `shopt -s globstar`, so `**` collapsed to a single `*` and only matched one directory level. This made it impossible to validate a filename at arbitrary depth (e.g. `**/phpunit.xml`). Enable `shopt -s globstar` in every step that expands `$GLOB_PATTERN` (List files, well-formedness, local schema, remote schema) so `**` matches across directory levels. Add recursive-glob test fixtures (valid files at depths 0/1/2, plus a variant whose only invalid file sits two levels deep) and matrix entries covering both well-formedness and local-XSD validation. Document the feature in the README. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
@AnHeuermann I appreciate your willingness to contribute, but AI usage is not acceptable in any form, which is why I will be closing this PR. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #41.
Changes
The
patterninput was expanded with unquoted bash pathname expansion withoutshopt -s globstar, so**collapsed to a single*and only matched one directory level. This made it impossible to validate a filename at arbitrary depth (e.g.**/phpunit.xml).Enable
shopt -s globstarin every step that expands$GLOB_PATTERN(List files, well-formedness, local schema, remote schema) so**matches across directory levels.Add recursive-glob test fixtures (valid files at depths 0/1/2, plus a variant whose only invalid file sits two levels deep) and matrix entries covering both well-formedness and local-XSD validation. Document the feature in the README.