-
Notifications
You must be signed in to change notification settings - Fork 529
fix: Fixed missing images #829 #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Progi1984 What do you think about this? |
@kw-pr I prefer this approach : kw-pr@6a549ba |
@Progi1984 I think this didn't work correctly. It adds all shapes, but I encountered errors with some of them. In the end, I only wanted the File shape. I'm not sure which other shapes we could safely add here. It feels excessive to incorporate this into ShapeCollection when it's only needed for a few specific shapes. Anyway, if you think this is the best approach I will create a new PR. |
Fixed in #845 |
Sorry, I did not fined the time to test this. |
Description
Added setContainer in Slide/AbstractSlide::createDrawingShape().
Fixes #820 createDrawingShape stopped working in 1.1.0
See #820 (comment) for details.
Checklist:
I think extra tests is not needed for a bugfix. There is no new code, not really.