Skip to content

Smaller package size by using export-ignore #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Smaller package size by using export-ignore #862

wants to merge 1 commit into from

Conversation

nreynis
Copy link

@nreynis nreynis commented Apr 3, 2025 •
edited
Loading

Description

The current dependency size is 44.8MB. Most of that weight shouldn't be in the user's vendor directory.

This PR adds a .gitattibutes file with export-ignore to keep distributed dependency size at bay.
See: https://php.watch/articles/composer-gitattributes

With this change, the dependency size drops to 1.13MB.

Fixes # (issue)

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@auto-assign auto-assign bot requested a review from Progi1984 April 3, 2025 11:22
@nreynis
Copy link
Author

nreynis commented Apr 3, 2025

I used https://github.com/PHPOffice/PhpSpreadsheet/blob/master/.gitattributes for reference

@coveralls
Copy link

coveralls commented Apr 3, 2025 •
edited
Loading

Coverage Status

coverage: 91.639%. remained the same
when pulling 7c75ea3 on nreynis:lighter-export
into 2919ce7 on PHPOffice:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Awaiting requested review from Progi1984

Assignees

@Progi1984 Progi1984

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nreynis @coveralls @Progi1984