Open
Conversation
Contributor
Author
|
Hey @Progi1984 if you can accept this I'd love to submit a few more and help with the next release |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR raises the minimum supported PHP version for PHPPresentation to PHP 7.4.
Recent versions of PhpSpreadsheet (a core dependency) now require PHP 7.4+, which means PHPPresentation can no longer install or run correctly on PHP 7.2 or 7.3.
CI was failing for these versions due to dependency resolution errors.
Changes in this PR:
Update Composer requirement from
^7.1 || ^8.0 → ^7.4 || ^8.0
Remove PHP 7.1–7.3 from GitHub Actions test matrices
Adjust coverage job from 7.3 → 7.4
Limit PHPStan analysis to the src directory to avoid unrelated legacy test warnings
PHP 7.4 reached end-of-life on 28 November 2022.