Conversation
mseaton
commented
Oct 7, 2025
| "url": "module/pihcore/downloadReport.form?reportUuid=004edb19-a3ac-11f0-9112-b688702e33e5&patientId={{patient.patientId}}", | ||
| "icon": "fas fa-fw fa-download", | ||
| "order": 51 | ||
| } |
Member
Author
There was a problem hiding this comment.
I had accidentally named this system_administration_extension.json when I added it initially, which isn't the right name, but more importantly would end up overwriting this file from config-pihemr: https://github.com/PIH/openmrs-config-pihemr/blob/master/configuration/appframework/system_administration_extension.json , so any of those extensions were being accidentally removed. You can likely confirm this on ces-ci @dmdesimone
dmdesimone
reviewed
Oct 8, 2025
Contributor
dmdesimone
left a comment
dmdesimone
left a comment
There was a problem hiding this comment.
SQL changes look good. Cannot comment on other config changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…board