Conversation
Member
|
@cioan ok, i'll need to review around the orderextension change. |
Member
|
Oops, didn't mean to close this, but not sure we want to merge this in with all of these changes. Will review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mseaton , the significant change that prevented the patient dashboard to load is here:
https://github.com/PIH/openmrs-module-rwandareports/compare/UP-120?expand=1#diff-057e2e92bf8c608af8420b6746485a00R27
The rest of the code removal is just removing the classes you removed in the orderextension module. There are a few other errors in the patientdashboard due to the changes you made to the orderextension but I will debug and fix those separately. This is just for the patient dashboard to load. Thanks!