Skip to content

fix: duplicate modification message output #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edragain2nd wants to merge 7 commits into
base: master
Choose a base branch
from
+1,128 −1,441
Open

fix: duplicate modification message output #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2150b24
fix issue
edragain2nd Nov 20, 2025
a9548e7
refactor modify
edragain2nd Nov 28, 2025
6a21bff
adjust res_usert
edragain2nd Dec 19, 2025
14998d1
adjust modify_user()
edragain2nd Dec 23, 2025
78cf563
refactor modifyqos
edragain2nd Dec 24, 2025
e12fab6
refactor modifyaccount
edragain2nd Dec 25, 2025
9e5af98
adjust
edragain2nd Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions protos/Crane.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,13 +341,17 @@ message DeleteQosReply {
repeated RichError rich_error_list = 2;
}

message ModifyFieldOperation {
ModifyField modify_field = 1; // modify item field
repeated string value_list = 2; // new value
OperationType type = 3;
}

message ModifyAccountRequest {
uint32 uid = 1;
ModifyField modify_field = 2; // modify item field
repeated string value_list = 3; // new value
string name = 4;
OperationType type = 5;
bool force = 6;
string name = 2;
repeated ModifyFieldOperation operations = 3;
bool force = 4;
}

message ModifyAccountReply {
Expand All @@ -357,13 +361,11 @@ message ModifyAccountReply {

message ModifyUserRequest {
uint32 uid = 1;
ModifyField modify_field = 2; // modify item field
repeated string value_list = 3; // new value
string name = 4;
string partition = 5;
OperationType type = 6;
string account = 8;
bool force = 9;
string name = 2;
string partition = 3;
string account = 4;
repeated ModifyFieldOperation operations = 5;
bool force = 6;
}

message ModifyUserReply {
Expand All @@ -373,14 +375,13 @@ message ModifyUserReply {

message ModifyQosRequest {
uint32 uid = 1;
ModifyField modify_field = 2; // modify item field
string value = 3; // new value
string name = 4;
string name = 2;
repeated ModifyFieldOperation operations = 3;
}

message ModifyQosReply {
bool ok = 1;
ErrCode code = 2;
repeated RichError rich_error_list = 2;
}

message QueryAccountInfoRequest {
Expand Down
Loading