Detect Array columns via Column#array - #260
Open
cbisnett wants to merge 1 commit into
Open
Conversation
The base ActiveRecord Column does not define array/array?; each adapter that supports arrays adds it on its own Column subclass (e.g. PostgreSQL). The ClickHouse Column never did, so tooling that detects array columns via `column.respond_to?(:array) && column.array` (such as annotaterb) silently treated `Array(...)` columns as their scalar subtype. Add `Column#array`, matching the top-level `Array(...)` SQL type, and have the schema dumper reuse it instead of re-deriving array-ness from a regex. Also fix the schema dumper's map-value regex so `Map(_, Array(_))` columns are dumped as `map: :array` (the intended single-option form) rather than relying on the previous match-anywhere behavior; both forms reload to the same SQL type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base ActiveRecord Column does not define array. Each adapter that supports arrays adds it on its own Column subclass (e.g. PostgreSQL). The ClickHouse Column never did, so tooling that detects array columns via
column.respond_to?(:array) && column.array(such as annotaterb) silently treatedArray(...)columns as their scalar subtype.Add
Column#array, matching the top-levelArray(...)SQL type, and have the schema dumper reuse it instead of re-deriving array-ness from a regex. Also fix the schema dumper's map-value regex soMap(_, Array(_))columns are dumped asmap: :array(the intended single-option form) rather than relying on the previous match-anywhere behavior; both forms reload to the same SQL type.