Skip to content

fix: Preserve sort with empty group {} #5635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
max-sixty merged 2 commits into from
Dec 21, 2025
Merged

fix: Preserve sort with empty group {} #5635

max-sixty merged 2 commits into from
Dec 21, 2025

Conversation

@max-sixty
Copy link
Member

@max-sixty max-sixty commented Dec 21, 2025

Summary

  • Fix sorting being incorrectly dropped when using group {} (sort a | take 1)
  • Empty group {} should preserve inner sort since there's no actual partitioning

Before:

SELECT * FROM foo LIMIT 1

After:

SELECT * FROM foo ORDER BY a LIMIT 1

Test plan

  • Added test test_group_empty_preserves_sort
  • Verified non-empty groups still work correctly (sort stays internal to partition)
  • All 631 tests pass
  • Lints pass

Fixes #5100

🤖 Generated with Claude Code

max-sixty and others added 2 commits December 20, 2025 18:01
@max-sixty @claude
fix: Return proper error for bare lambda expressions
d9c78f1 
Replace internal compiler error with user-facing error message when a
bare lambda like `x -> y` is used at the top level. Now produces:
"expected a table, but found a function"

Fixes PRQL#4280

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@max-sixty @claude
fix: Preserve sort with empty group {}
f9a3c02 
When using `group {} (sort a | take 1)`, the inner sort was being
incorrectly dropped because `sort_undone` was unconditionally set
to true for all groups. Now only set `sort_undone` when there's an
actual partition (non-empty group keys).

Fixes PRQL#5100

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@max-sixty max-sixty merged commit 394c590 into PRQL:main Dec 21, 2025
35 checks passed
@max-sixty max-sixty deleted the bug-fixes branch December 21, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sorting disappears with empty group

1 participant

@max-sixty