Skip to content

fix: typos and stray leading space in date format#5864

Merged
max-sixty merged 5 commits into
mainfrom
fix/nightly-survey-2026-05-07
May 7, 2026
Merged

fix: typos and stray leading space in date format#5864
max-sixty merged 5 commits into
mainfrom
fix/nightly-survey-2026-05-07

Conversation

@prql-bot
Copy link
Copy Markdown
Collaborator

@prql-bot prql-bot commented May 7, 2026

Summary

Findings from the nightly survey (2026-05-07). Three small documentation/correctness fixes:

  • prqlc/prqlc/src/sql/pq/anchor.rs: Fix two doc-comment typos referring to "proceeding pipeline" — the variable in code is preceding, and these functions split a pipeline into the preceding (earlier) part and the atomic (last) part. Also fix SELECTTedselected in the Sort requirements comment (using lowercase to match the existing convention in this file — SELECTed was reverted by the typos pre-commit hook, which tokenizes the camelCase boundary as SELEC and "corrects" it back).

  • web/book/src/reference/syntax/arrays.md: Grammar fix — "Number of fields can be vary." → "Number of fields can vary."

  • web/website/themes/prql-theme/layouts/_default/article.html: Remove a stray leading space inside the Go time-format string passed to .Date.Format/.Lastmod.Format. The previous " 2006-01-02T15:04:05Z07:00" rendered into <time datetime=" 2026-…"> with a leading space; browsers tolerate it, but the rendered attribute should be a clean ISO 8601 string.

Test plan

  • task prqlc:test passes
  • All changes are pure documentation, comments, or a template format-string tweak; no behavioral test added (the article.html change has no automated rendering test in the repo).

prql-bot and others added 5 commits May 7, 2026 07:28
Three small fixes from nightly survey:
- anchor.rs: 'proceeding pipeline' -> 'preceding pipeline' (two doc
  comments); 'SELECTTed' -> 'SELECTed'.
- arrays.md: 'can be vary' -> 'can vary'.
- article.html: drop leading space in .Date.Format / .Lastmod.Format
  argument so the rendered <time datetime> attribute is a clean
  ISO 8601 string.
The original commit changed `SELECTTed` to `SELECTed` in the Sort
requirements comment, but the typos pre-commit hook tokenizes the
camelCase boundary as `SELEC` and "corrects" it back to `SELECTTed`.
Use lowercase `selected` (already the convention in this file — see
lines 429, 562) so the fix actually lands.

Co-Authored-By: Claude <noreply@anthropic.com>
Companion to the line-565 fix in this PR.

Co-Authored-By: Claude <noreply@anthropic.com>
Same fix as the article.html change in this PR — list.html had the
identical leading space inside the Go time-format string passed to
.Date.Format.

Co-Authored-By: Claude <noreply@anthropic.com>
@max-sixty max-sixty merged commit b5091ab into main May 7, 2026
36 checks passed
@max-sixty max-sixty deleted the fix/nightly-survey-2026-05-07 branch May 7, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants