docs: remove deprecated count_distinct from aggregate.md#5865
Merged
Conversation
The function is annotated @{deprecated} in std.prql but the docs list it
without that note.
Member
|
remove deprecated things from docs |
Per maintainer feedback, drop the deprecated function from the list rather than marking it deprecated.
prql-bot
changed the title
Collaborator
Author
|
Updated to drop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aggregate transform docs list
count_distinctalongside other aggregation functions. Inprqlc/prqlc/src/semantic/std.prql:162,count_distinctis annotated@{deprecated}in favor of filtering input tostd.count. Drop it from the docs so readers don't reach for it as a current option.Found during nightly code survey.