Skip to content

fix: resolve duplicate login error popups and improve error robustness#77

Open
harrshita123 wants to merge 1 commit intoPSMRI:developfrom
harrshita123:fix/duplicate-login-popups
Open

fix: resolve duplicate login error popups and improve error robustness#77
harrshita123 wants to merge 1 commit intoPSMRI:developfrom
harrshita123:fix/duplicate-login-popups

Conversation

@harrshita123
Copy link
Copy Markdown

@harrshita123 harrshita123 commented May 4, 2026

📋 Description

Summary: This PR fixes a bug on the login page where users would see two separate error popups at the same time when entering wrong credentials. I’ve also improved the error messaging to make it more reliable.

Issue: #124


Key Changes:

Updated the HTTP Interceptor to stop showing global error messages specifically for the login API. This prevents the "double popup" issue.
Refactored the Login Component's error handling to be more robust. It now correctly handles different types of server errors (like 500 Internal Errors) and avoids showing broken messages like "undefinedundefined".


✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • New feature (non-breaking change which adds functionality)
  • 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Refactor (change that is neither a fix nor a new feature)
  • ⚙️ Config change (configuration file or build script updates)
  • 📚 Documentation (updates to docs or readme)
  • 🧪 Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • 🚀 Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

ℹ️ Additional Information
How it was tested:

Invalid Login: Entered wrong credentials and verified that only one clean "Unauthorized" popup appears. Server Downtime: Stopped the local API and verified that the UI shows a readable error message instead of crashing or showing "undefined".

Verification: Tested on both develop and main branches to ensure compatibility.


Screenshot 2026-05-04 at 11 32 41 AM

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7b2bf88b-e588-4f30-a7b4-58cfab20bd88

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@drtechie
Copy link
Copy Markdown
Member

drtechie commented May 6, 2026

Seems to be duplicate code as #79
Check the comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants