vue: add composition api example #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new vue example based on the new composition API.
iperzic
reviewed
Feb 11, 2025
|
Yes |
iperzic
approved these changes
Feb 11, 2025
miguelcalderon
approved these changes
Feb 11, 2025
| "type-check": "vue-tsc --build" | ||
| }, | ||
| "dependencies": { | ||
| "pspdfkit": "^2024.8.1", |
There was a problem hiding this comment.
Can we use the new package instead, please?:
Suggested change
| "pspdfkit": "^2024.8.1", | |
| "@nutrient-sdk/viewer": "^1.0.0", |
| let PSPDFKit: typeof import("pspdfkit").default | undefined; | ||
|
|
||
| onMounted(async () => { | ||
| PSPDFKit = (await import("pspdfkit")).default; |
There was a problem hiding this comment.
Suggested change
| PSPDFKit = (await import("pspdfkit")).default; | |
| PSPDFKit = (await import("@nutrient-sdk/viewer")).default; |
| import { onMounted, onUnmounted, useTemplateRef } from "vue"; | ||
|
|
||
| const containerRef = useTemplateRef("container"); | ||
| let PSPDFKit: typeof import("pspdfkit").default | undefined; |
There was a problem hiding this comment.
Suggested change
| let PSPDFKit: typeof import("pspdfkit").default | undefined; | |
| let PSPDFKit: typeof import("@nutrient-sdk/viewer").default | undefined; |
| copy({ | ||
| targets: [ | ||
| { | ||
| src: "node_modules/pspdfkit/dist/pspdfkit-lib", |
There was a problem hiding this comment.
Suggested change
| src: "node_modules/pspdfkit/dist/pspdfkit-lib", | |
| src: "node_modules/@nutrient-sdk/viewer/dist/nutrient-viewer-lib", |
| *.tsbuildinfo | ||
|
|
||
| # Web SDK static files | ||
| public/pspdfkit-lib/ |
There was a problem hiding this comment.
Suggested change
| public/pspdfkit-lib/ | |
| public/nutrient-viewer-lib/ |
|
Oops, thanks for the review @miguelcalderon I merged this before I saw your review but I'm working to nutrify all three migrated examples in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new vue example based on the new composition API. Added this as a new directory since previous example is written in the old options API and likely used as reference in various places.