Merged
Conversation
Add a windows-x64 job to the release workflow that builds hawkeye.exe with MSVC, stages the binary alongside its assets, and uploads a self-contained ZIP to the GitHub release. Fix asset_path.c on Windows: populate user-data dir from %APPDATA% and resolve the install dir from the running executable, so the portable ZIP works from any extract location without relying on the compile-time Unix install prefix. Closes PX4#80
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #80 — adds prebuilt Windows binaries so users no longer need to compile from source.
Summary
windows-x64job in.github/workflows/release.ymlthat compileshawkeye.exewith MSVC onwindows-latest, stages it alongsidemodels/,shaders/,fonts/,textures/,themes/,LICENSE, andREADME.md, and uploadshawkeye-<version>-windows-x64.zipas a release asset on everyv*tag.src/asset_path.cfor Windows: user-data dir now resolves to%APPDATA%\hawkeye(was unset, causingasset_write_pathto fall back to CWD and break screenshot/marker saves when the exe ran from a non-writable location); install dir now resolves fromGetModuleFileNameA()rather than the compile-timeHAWKEYE_INSTALL_DATADIR(which encodes a Unix-style/usr/share/...layout inappropriate for a portable ZIP).README.md,docs/installation.md, anddocs/developer/build.mdto point Windows users at the ZIP and note the SmartScreen caveat on first launch.Test plan
cmake --build ... --config Release)hawkeye.exeruns from the build dirhawkeye.exe+ assets to%TEMP%\hawkeye-portable-test\and launching from there renders the default quadrotor scene (confirms exe-dir asset resolution)hawkeye --helpexits cleanly beforeInitWindow, enabling the CI smoke testv*tag to confirm the ZIP is produced and uploadedFollow-ups (out of scope)
MSVC_RUNTIME_LIBRARY MultiThreaded) to eliminate theVCRUNTIME140.dlldependency for users on clean Windows installsCloses #80