arch/esp32_spi.c & esp32_wifi_adapter.c amendments#342
Closed
henrykotze wants to merge 1 commit intoPX4:px4_firmware_nuttx-10.3.0+from
Closed
arch/esp32_spi.c & esp32_wifi_adapter.c amendments#342henrykotze wants to merge 1 commit intoPX4:px4_firmware_nuttx-10.3.0+from
henrykotze wants to merge 1 commit intoPX4:px4_firmware_nuttx-10.3.0+from
Conversation
- esp32_wifi_adapted.c: ESP32 SoftAP Mode depends on some STA mode functions. Moved those
dependent functions out of the include guard of the ESP32_WLAN_HAS_STA
- esp32_spi.c : resolved: compiler error: taking the absolute value of
unsigned type 'uint32_t' {aka 'unsigned int'} has no effect
6 tasks
mrpollo
reviewed
Jul 24, 2025
|
|
||
| ret = esp_wifi_internal_reg_rxcb(ESP_IF_WIFI_AP, (wifi_rxcb_t)recv_cb); | ||
| // ret = esp_wifi_internal_reg_rxcb(ESP_IF_WIFI_AP, (wifi_rxcb_t)recv_cb); | ||
| ret = esp_wifi_internal_reg_rxcb(1, (wifi_rxcb_t)recv_cb); |
There was a problem hiding this comment.
What is the value of 1, true? Or is that something else?
Author
There was a problem hiding this comment.
The value of 1 refers to the enum ESP_IF_WIFI_AP, which means the ESP's WiFi is operating soft-AP mode.
copied from the PR description:
The compiler cannot find the enum value of ESP_IF_WIFI_AP. This enum is dependent on the esp-wireless-drivers-3rdparty repo. (More on this in the description)
That is also why i commented out the original code, since this issue will either be solved in upstream, and thus we can revert it once we pull in the newer Nuttx versions.
Author
|
Closing, since I managed to find the problem during linking in PX4 side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is working alongside PX4/PX4-Autopilot#24887, to get PX4 running on the ESP32.
esp32_wifi_adapted.c: ESP32 SoftAP Mode depends on some STA mode functions. Moved those dependent functions out of the include guard of the ESP32_WLAN_HAS_STA
esp32_spi.c : resolved compiler error: taking the absolute value of unsigned type 'uint32_t' {aka 'unsigned int'} has no effect
The compiler cannot find the enum value of ESP_IF_WIFI_AP. This enum is dependent on the esp-wireless-drivers-3rdparty repo. The files of interest to resolve this issue are:
/src/include/esp_wifi_types.hThe other file of interest to resolve this would be
/src/include/esp_wifi_interface.h:To resolve the compiler not being able to find
WIFI_IF_AP. I just hardcoded it for now to 1. Any guidance on getting it to compiled via the correct header would be appreciated. (I have tried including bothesp_wifi_interface.handesp_wifi_types.hwith no success.